NOTE! mkfs.ubifs

[Adrian Hunter]

Artem Bityutskiy wrote:
> On Tue, 2010-09-07 at 11:36 +0300, Artem Bityutskiy wrote:
>> From: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
>>
>> When mkfs.ubifs is used with -r dir, it does not make the root UBIFS
>> inode uid/gid/permissions to be equivalent to dir's permissions, but
>> it makes root inode permissions to be equivalent to uid = git = 0
>> (root) and permissions = u+rwx go+rx.
>>
>> This patch changes the behavior and makes mkfs.ubifs use the
>> permissions of the directory containing the original files on the host.
>> I.e., it will be <dir>'s uid/git/permissions if case of mkfs.ubifs
>> -r <dir>.
>>
>> This patch is a bit dangerous because it changes the behavior and may
>> have security implications if someone used the older version, relied
>> on this bug, and upgrades to the newer version.
>>
>> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
> 
> All mkfs.ubifs users should take a look at this - should we apply this
> patch? I'm still in doubt...
> 

I do not agree with changing the behaviour.  It should be a new option,
and you could add a warning explaining what the root inode permissions
are and why e.g.

	Warning: Option ?? not used. Setting root inode permissions to blah

	Warning: Option ?? used. Setting root inode permissions to blah