[PATCH 2 2/3] mtd: cfi_cmdset_0002: add CFI detection for SST 38VF640x chips

David Woodhouse david.woodhouse at intel.com
Tue Oct 26 06:29:17 EDT 2010


On Tue, 2010-10-26 at 11:25 +0100, Wolfram Sang wrote:
> > +	/*
> > +	 * CFI reports 1024 sectors (0x03ff +1) of 64KBytes (0x0100 *256) where
> > +	 * it should report a size of 8KBytes (0x0020 *256).
> 
> Spaces after operators?
> 
> > +	 */
> > +	cfi->cfiq->EraseRegionInfo[0] = 0x002003ff;
> > +	pr_warning("%s: Bad 38VF640x CFI data, adjust sector size from 64 to 8KBytes\n", mtd->name);
> 
> Should be "adjusting", otherwise it sounds like a task for the user to do.

And s/KBytes/KiB/ while we're nitpicking.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse at intel.com                              Intel Corporation




More information about the linux-mtd mailing list