[PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices
Scott Wood
scottwood at freescale.com
Mon Oct 18 12:06:31 EDT 2010
On Mon, 18 Oct 2010 16:55:49 +0800
"tiejun.chen" <tiejun.chen at windriver.com> wrote:
> Looks you always iounmap(fsl_lbc_ctrl_dev->regs) on position 'err' but here
> of_iomap() is already failed you should skip iounmap() fsl_lbc_ctrl_dev->regs
> again. So you should improve that as the following on 'err', or layout 'err' in
> gain.
> ------
> if(fsl_lbc_ctrl_dev->regs)
> iounmap(fsl_lbc_ctrl_dev->regs);
>
It looks like iounmap(NULL) is a no-op, just like kfree(NULL).
-Scott
More information about the linux-mtd
mailing list