[PATCH v2 2/3] mtd-utils: nanddump: Dynamic buffer, increase pagesize/oobsize

Artem Bityutskiy dedekind1 at gmail.com
Sat Oct 16 15:34:48 EDT 2010


On Fri, 2010-10-15 at 17:35 -0700, Brian Norris wrote:
> The buffers used for dumping page and OOB data needed dynamic
> allocation to help eliminate burdens for updating (i.e., every
> time there's a new OOB size we don't have to increase the sizes).
> 
> Also, there is no need to check flash chips for "standard sizes."
> With recent changes to the printing codebase, we should be able to
> handle arbitrary sizes with no problem.
> 
> More exit operations are now necessary on program failure, so
> "goto closeall" is used more liberally.
> 
> Also, common.h is included for the use of xmalloc.
> 
> Signed-off-by: Brian Norris <computersforpeace at gmail.com>

The patches look OK for me, but I'll wait a little in case there is
going to be more review.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)




More information about the linux-mtd mailing list