[PATCH] jffs2: Fix serious write stall due to erase

Joakim Tjernlund joakim.tjernlund at transmode.se
Tue Oct 12 04:55:29 EDT 2010


Artem Bityutskiy <dedekind1 at gmail.com> wrote on 2010/10/12 10:42:39:
>
> On Thu, 2010-10-07 at 18:01 +0200, Joakim Tjernlund wrote:
> > Drop the alloc_sem before erasing flash in
> > jffs2_garbage_collect_pass().
> > Otherwise writes are put on hold until the erase
> > has finised.
> >
> > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund at transmode.se>
> > ---
> >
> >  I am fairly sure it is safe to unlock the alloc_sem before
> >  calling jffs2_erase_pending_blocks(). Extra confirmation
> >  would be great though.
> >
> >  This problem was introduced in 2.6.35
>
> This looks safe for me as well, but I do not remember JFFS2 locking
> rules anymore, so I'm not 100% sure. I've pushed your patch to my
> l2-mtd-2.6.git.

Thanks, now if just David could weigh in :)

      Jocke




More information about the linux-mtd mailing list