[PATCH] mtd/nand.h: cleanups
Artem Bityutskiy
dedekind1 at gmail.com
Tue Oct 5 14:48:26 EDT 2010
On Tue, 2010-10-05 at 20:26 +0200, Wolfram Sang wrote:
> Hi Sebastian,
>
> just a minor comment.
[Side note: it is much more reader-friendly to avoid citing whole patch
and making the readers search where you put the comment, like this:]
> > @@ -457,24 +492,32 @@ struct nand_chip {
> >
> > uint8_t (*read_byte)(struct mtd_info *mtd);
> > u16 (*read_word)(struct mtd_info *mtd);
> > - void (*write_buf)(struct mtd_info *mtd, const uint8_t *buf, int len);
> > - void (*read_buf)(struct mtd_info *mtd, uint8_t *buf, int len);
> > - int (*verify_buf)(struct mtd_info *mtd, const uint8_t *buf, int len);
> > + void (*write_buf)(struct mtd_info *mtd, const uint8_t *buf,
> > + int len);
>
> It might be more readable to get rid of the tabs after the type and keep the
> arguments in one line?
I agree with this. Sebastian, I'll put your patch to my l2 tree when
git.infradead.org is back. But if you could send a separate follow up
patch which kills these ugly tabs - it would be nice.
--
Best Regards,
Artem Bityutskiy (Битюцкий Артём)
More information about the linux-mtd
mailing list