Suggested patch: reset errno after isatty()
vapier.adi at gmail.com
Wed Nov 24 16:36:04 EST 2010
On Wed, Nov 24, 2010 at 09:30, Ketil Froyn wrote:
> On Wed, Nov 24, 2010 at 3:12 PM, Artem Bityutskiy wrote:
>> So it dies very soon. You should easily find the line of code where this
>> happens with gdb. Just compile nanddump with -g -O0
> It's just that I have limited tools on my device where this happens.
> But I've finally pinned it!
> There's a couple of issues, I guess. Firstly, calling mtd_read_oob()
> with an oob_size of 0 segfaults, which I guess it shouldn't. I haven't
> looked into that. The problem here was that the oob_size was set to 0,
> and that happens because the legacy code forgot to set it. This patch
> fixes it for me:
awesome. can you post your signed-off-by tag and/or a proper git patch please ?
More information about the linux-mtd