[PATCH 01/10] mtd-utils: nanddump: Allow 64-bit lengths
Artem Bityutskiy
dedekind1 at gmail.com
Sat Nov 13 06:31:58 EST 2010
On Wed, 2010-11-03 at 01:27 -0700, Brian Norris wrote:
> We should allow the dump length to be 64-bit, especially since the value
> was read in as a "long long" by strtoll().
>
> Signed-off-by: Brian Norris <computersforpeace at gmail.com>
> ---
> nanddump.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/nanddump.c b/nanddump.c
> index 86a71c9..fe29596 100644
> --- a/nanddump.c
> +++ b/nanddump.c
> @@ -83,7 +83,7 @@ static bool noecc = false; // don't error correct
> static bool noskipbad = false; // don't skip bad blocks
> static bool omitoob = false; // omit oob data
> static unsigned long long start_addr; // start address
> -static unsigned long length; // dump length
> +static unsigned long long length; // dump length
> static const char *mtddev; // mtd device name
> static const char *dumpfile; // dump file name
> static bool omitbad = false;
This patch does not apply. Which version of MTD utils do you use? This
change was done long time ago by the following commit:
commit b16c1b630491a461b3ebb55d714d7bb0cd122737
Author: Grant Erickson <gerickson at nuovations.com>
Date: Sun Sep 7 20:45:21 2008 +0000
nanddump: Qualifier Clean-up
Static-qualified all globals except 'main' because they have no use
beyond file scope.
Constant-qualified MTD device and input positional parameter globals.
Constant-qualified argv array.
Signed-off-by: Grant Erickson <gerickson at nuovations.com>
Acked-by: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
Signed-off-by: Josh Boyer <jwboyer at gmail.com>
Forgot to git-pull ? :-))))
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
More information about the linux-mtd
mailing list