[PATCH UPDATED 1/5] mtd: fix bdev exclusive open bugs in block2mtd::add_device()

Artem Bityutskiy dedekind1 at gmail.com
Sat Nov 13 06:14:25 EST 2010

On Sat, 2010-11-13 at 11:59 +0100, Tejun Heo wrote:
> There are two bdev exclusive open bugs.
> * open_bdev_exclusive() must not be called with NULL holder.  Use dev
>   as the holder.
> * open_by_devnum() doesn't open the bdev exclusively but
>   block2mtd_free_device() always assumes it.  Explicitly claim the
>   bdev.
> The latter is rather clumsy but will be simplified with future
> blkdev_get/put() cleanups.
> - Updated to use local variable @mode to cache FMODE_* masks as
>   suggested by Artem Bityutskiy.

Do you want this patch to go in via Jens' tree with the rest of the
series, or as an independent patch via the mtd tree?


Acked-by: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>


Best Regards,
Artem Bityutskiy (Артём Битюцкий)

More information about the linux-mtd mailing list