[PATCH 09/10] mtd-utils: nanddump: type consistency
Mike Frysinger
vapier.adi at gmail.com
Tue Nov 9 04:51:36 EST 2010
On Wed, Nov 3, 2010 at 04:27, Brian Norris wrote:
> nandwrite.c | 6 +++---
the subject says "nanddump" ...
> --- a/nandwrite.c
> +++ b/nandwrite.c
> @@ -262,7 +262,7 @@ int main(int argc, char * const argv[])
> long long blockstart = -1;
> struct mtd_dev_info mtd;
> struct mtd_oob_buf oob;
> - loff_t offs;
> + long long offs;
> int ret;
> int oobinfochanged = 0;
> struct nand_oobinfo old_oobinfo;
i dont think this is quite right. "offs" is given to an ioctl which
takes __kernel_loff_t ... we shouldnt assume "long long" and
"__kernel_loff_t" are always the same.
-mike
More information about the linux-mtd
mailing list