[PATCH RESEND v5 4/5] omap: nand: ecc layout select from board file
notasas at gmail.com
Thu Nov 4 06:56:57 EDT 2010
On Thu, Nov 4, 2010 at 12:15 PM, Ghorai, Sukumar <s-ghorai at ti.com> wrote:
>> -----Original Message-----
>> From: Grazvydas Ignotas [mailto:notasas at gmail.com]
>> OMAP3 pandora.
>> What I wanted to say is that current mainline code has hw ECC forced
>> which is wrong for some boards, and this patch did not make into last
>> merge window, so NAND is broken. It would be good to take this patch
>> out of larger series you sent earlier and resend as a fix for -rc1, so
>> that NAND works on 2.6.37. It's not too large and should probably be
>> ok for -rc2.
> There is an additional patch I will send (with this series by next week) to select the ECC from board file, such that different board file can select the different ECC method.
> 1. This is mainly for OMAP3630 onwards and has been aligned with many customers to use the hw ecc.
> 2. I did not understand how it's not working, would you please explain again? If you apply the series then it's storing the same ecc value in different location and generated from h/w module.
It most likely works (need to test more), I was just complaining it's
not upstream and sw ecc is broken on both 2.6.36 and 2.6.37.
> 3. This patches are not upstream yet; send me the git-link you referring that these patches are available in 2.6.37?
Correct, they are not upstream, so that's why suggest sending smaller
fix patch for 2.6.37-rc2, so that sw ecc works on 2.6.37.
More information about the linux-mtd