Wrong flash type in m25p80 driver

[Mike Frysinger]

On Sun, May 16, 2010 at 15:04, Shachar Shemesh wrote:
> Mike Frysinger wrote:
>> 2010/5/16 Shachar Shemesh:
>>> The second problem I'm having with this driver is that it reports itself as
>>> NOR flash.
>>
>> the response is: so what ?  you havent described how this is
>> problematic in any way.
>
> Then why have flash type at all, if no-one cares?

so your answer is "there is no problem with calling it NOR flash"

if it looks like a duck, quacks like a duck, and walks like a duck,
then why waste time calling it a DataDuck ?  for all intents and
purposes, all the kernel code/utilities that work with the flashes can
treat these SPI flashes as NOR flashes and everything works fine.

> Either way, the patch in my previous message is intended for inclusion.

it isnt acceptable in the current format.  so until you clean it up
and submit it properly, nothing is going to happen.

this of course ignores the errors in the patch like calling it
DataFlash which you yourself clearly have shown is wrong.  DataFlash
is a special type of flash made by Atmel.  it has properties which
other SPI flashes do not.
-mike