[PATCH v3] mtdchar: fix mmap() for MTD RAM/ROM char devices

Anatolij Gustschin agust at denx.de
Mon Jun 14 05:22:13 EDT 2010


On Sat, 12 Jun 2010 21:31:11 -0400
Mike Frysinger <vapier.adi at gmail.com> wrote:

> On Sat, Jun 12, 2010 at 15:35, Anatolij Gustschin wrote:
> > For no-mmu systems mmap() on RAM/ROM devices already works
> > but for systems with mmu it probably was not tested and
> > currently doesn't work.
> 
> nope, never did

Do you mean it never worked on mmu systems?

> 
> > +               if (vma->vm_pgoff > (~0UL >> PAGE_SHIFT))
> > +                       return -EINVAL;
> 
> i'm pretty sure this is inappropriate and doesnt belong here

Then I'll drop this in the next patch.

Thanks,
Anatolij



More information about the linux-mtd mailing list