mkfs.ubifs gives corrupt images/crc errors

[Leo Barnes]

> Could you please find the commit which moves CRC support out of
> mtd-utils/mkfs.ubifs and investigate what changed please? I think you
> will find the reason quite quickly.
>
> I'm on holiday, cannot look at this now.

I have now identified the first broken commit to be:

commit 2d40ed7b415bcb6a358c9f221160c4a419f01f19
Author: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
Date:   Sat Jul 17 09:43:08 2010 +0300

    libs: make crc32 and fec to be libraries


When looking at what this commit does, I can't understand why it
breaks the CRC-calculation for mkfs.ubifs since all it seems to do is
to create a library archive out of the crc files (after renaming them)
and change the crc32() function from being static inline to normal. No
function calls in mkfs.ubifs are changed, and the new crc32() function
seems to do exactly the same thing as the old.

Has anyone else noticed this problem, or is my device more susceptible
to this for some odd reason?

Best regards,
//Leo