[PATCH v3 2/2] mtd-utils: clean up compile warnings

Mike Frysinger vapier.adi at gmail.com
Fri Jul 23 22:12:53 EDT 2010


On Fri, Jul 23, 2010 at 20:47, Kevin Cernekee <cernekee at gmail.com> wrote:
> -static char *helptext =
> +static const char *helptext =

might as well fix this while you're changing things:
static const char helptext[] =

> -static char *revtext = "1.60";
> +static const char *revtext = "1.60";

here too

> -       printf ("Copied %d bytes from address 0x%.8x in flash to %s\n",len,offset,filename);
> +       printf ("Copied %d bytes from address 0x%.8x in flash to %s\n",
> +               (int)len,offset,filename);

please fix the format strings instead of casting away the types.  this
should be %zu instead of %d for the len.  i imagine there are a bunch
of similar changes in this patch that should be fixed correctly.
-mike



More information about the linux-mtd mailing list