[PATCH 2/2] Remove now-defunct ts7250 nand driver

David Woodhouse dwmw2 at infradead.org
Wed Jan 6 12:42:17 EST 2010


On Wed, 2010-01-06 at 12:26 -0500, H Hartley Sweeten wrote:
> Ok, that's really strange.  I just looked at the email I sent and that line
> is:
> 
> - *   Copyright (C) 2004 Marius Gröger (mag at sysgo.de)

Your previous email was in iso8859-1, a legacy charset that really has
no business being used this century. You can see the charset in its
Content-Type: header:
	Content-type: text/plain; charset="iso-8859-1"

The ö was therefore encoded as a single byte 0xf6. When we save the mail
to disk and apply it as a patch, that 0xf6 doesn't actually match what's
in the file you were patching -- and thus the patch didn't apply.

> The character must have been converted as the message left my outbox.

Probably, yes.

> Hmmmm.. What should my default character set be?  It looks like my mailer is
> setup to use these (in this order):

Did you change anything already? Although your older mail was iso8859-1,
the mail to which I'm replying now is different. It's:
	Content-type: text/plain; charset="utf-8"

So this time the ö is encoded as two bytes (0xc3, 0xb6) and _does_ match
what's in the kernel source files. If you'd included the patch in _this_
mail, it would have applied.

> us-ascii
> iso-8859-1
> utf-8 (locale)
> utf-8

It's iso-8859-1 which is causing the problem. Because your mail only
used characters which can be represented in iso8859-1, it got converted
to that. Drop iso8859-1 and it should be fine. ASCII is fine because
it's a subset of UTF-8. Any ASCII text is also valid UTF-8.

-- 
dwmw2




More information about the linux-mtd mailing list