[PATCH] mtd: maps: Blackfin async: rename local funcs to avoid common clashes

Mike Frysinger vapier.adi at gmail.com
Thu Feb 25 06:50:12 EST 2010


On Thu, Feb 25, 2010 at 06:32, David Woodhouse wrote:
> On Sun, 2010-01-17 at 10:52 -0500, Mike Frysinger wrote:
>>         state->map.name       = DRIVER_NAME;
>> -       state->map.read       = bfin_read;
>> -       state->map.copy_from  = bfin_copy_from;
>> -       state->map.write      = bfin_write;
>> -       state->map.copy_to    = bfin_copy_to;
>> +#ifdef CONFIG_MTD_COMPLEX_MAPPINGS
>> +       state->map.read       = bfin_flash_read;
>> +       state->map.copy_from  = bfin_flash_copy_from;
>> +       state->map.write      = bfin_flash_write;
>> +       state->map.copy_to    = bfin_flash_copy_to;
>> +#endif
>
> Why add the #ifdef? This driver depends on MTD_COMPLEX_MAPPINGS in
> Kconfig, and rightly so -- it can never work as a 'simple' mapping.

it was to allow for quick build test w/out having to create a valid
configuration file
make drivers/mtd/maps/bfin-async-flash.o
-mike



More information about the linux-mtd mailing list