Re-2: [PATCH 2/2] s/jffs2_erase_pending_trigger/jffs2_garbage_collect_trigger/

[Kai-Uwe Bloem]

> > But then you make the code more confusing. Indeed, readability becomes
> > worse.
> >
> > I would just change 'jffs2_erase_pending_trigger()' and make it wake up
> > the GC thread, just like 'jffs2_garbage_collect_trigger()'...
> 
> Depends on your point of view, I think erasing blocks is GC so to
> me it makes sense. However I acknowledge that erasing is different from
> other forms of GC so I can change it back if you really want me too.

Yes, please. I too think that it would be more readable, since the intention is more visible.

--


To: joakim.tjernlund at transmode.se
    dedekind1 at gmail.com
Cc: linux-mtd at lists.infradead.org