[PATCH v3 2/2] Adding nand lock/unlock routines.

Vimal Singh vimal.newwork at gmail.com
Tue Feb 16 03:55:29 EST 2010


On Tue, Feb 16, 2010 at 1:48 PM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> On Mon, 2010-02-15 at 20:20 +0530, Vimal Singh wrote:
>> On Mon, Feb 15, 2010 at 8:05 PM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
>> > On Mon, 2010-02-08 at 15:50 +0530, Vimal Singh wrote:
>> >> This version fixes the compilation break reported by Kishore. 1st
>> >> patch in this series remains untouched.
>> >>
>> >> -vimal
>> >>
>> >> From a28c230f3bd8fa765f78c0be91370f146e71f670 Mon Sep 17 00:00:00 2001
>> >> From: Vimal Singh <vimalsingh at ti.com>
>> >> Date: Wed, 3 Feb 2010 14:32:06 +0530
>> >> Subject: [PATCH 2/2] Adding nand lock/unlock routines.
>> >>
>> >> Adding nand lock / unlock routines. At least 'micron' parts
>> >> support this.
>> >>
>> >> Signed-off-by: Vimal Singh <vimalsingh at ti.com>
>> >
>> > These look OK to me, except the part where you export them. Why they
>> > should be exported?
>>
>> There was an earlier comment (in 1st RFC version of the patch), where
>> you said probably it is not safer to assign mtd lock and unlock
>> pointers in 'nand_scan_tail', as not all flashes have this feature.
>>
>> So, I exported these so that a driver can use these by overwriting mtd
>> lock and unlock pointers in its probe.
>
> OK, push to my l2-mtd-2.6.git / master

Thanks.

-- 
Regards,
Vimal Singh



More information about the linux-mtd mailing list