[PATCH 2/7] omap3: nand: configurable transfer type per board
Ghorai, Sukumar
s-ghorai at ti.com
Wed Dec 22 02:52:12 EST 2010
> -----Original Message-----
> From: Tony Lindgren [mailto:tony at atomide.com]
> Sent: Saturday, December 18, 2010 5:39 AM
> To: Ghorai, Sukumar
> Cc: linux-omap at vger.kernel.org; linux-mtd at lists.infradead.org; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCH 2/7] omap3: nand: configurable transfer type per board
>
> * Sukumar Ghorai <s-ghorai at ti.com> [101126 07:25]:
> > nand transfer type (sDMA, Polled, prefetch) can be select from board
> file,
> > enabling all transfer type in driver, by default.
> >
> > this helps in multi-omap build and to select different transfer type for
> > different board.
> >
> > Signed-off-by: Sukumar Ghorai <s-ghorai at ti.com>
> > ---
> > arch/arm/plat-omap/include/plat/nand.h | 7 +++
> > drivers/mtd/nand/Kconfig | 17 ------
> > drivers/mtd/nand/omap2.c | 92 +++++++++++--------------
> ------
> > 3 files changed, 40 insertions(+), 76 deletions(-)
> >
> > diff --git a/arch/arm/plat-omap/include/plat/nand.h b/arch/arm/plat-
> omap/include/plat/nand.h
> > index 6562cd0..78c0bdb 100644
> > --- a/arch/arm/plat-omap/include/plat/nand.h
> > +++ b/arch/arm/plat-omap/include/plat/nand.h
> > @@ -10,6 +10,12 @@
> >
> > #include <linux/mtd/partitions.h>
> >
> > +enum nand_io {
> > + NAND_OMAP_PREFETCH_POLLED = 0, /* prefetch polled mode, default
> */
> > + NAND_OMAP_POLLED, /* polled mode, without prefetch */
> > + NAND_OMAP_PREFETCH_DMA /* prefetch enabled sDMA mode */
> > +};
> > +
> > struct omap_nand_platform_data {
> > unsigned int options;
> > int cs;
> > @@ -20,6 +26,7 @@ struct omap_nand_platform_data {
> > int (*nand_setup)(void);
> > int (*dev_ready)(struct omap_nand_platform_data *);
> > int dma_channel;
> > + enum nand_io xfer_type;
> > unsigned long phys_base;
> > int devsize;
> > };
>
> So maybe the devsize in patch 1/7 should be handled with this too?
[Ghorai] patch 1/7 [1] is to select the NAND type i.e. x8 or x16 NAND;
So I am keeping as separate patch. And let me know if I am missing anything.
[1] https://patchwork.kernel.org/patch/359092/
More information about the linux-mtd
mailing list