[PATCH v2 5/8] nanddump: check for negative inputs

Brian Norris computersforpeace at gmail.com
Wed Dec 1 01:18:23 EST 2010


Includes error messages for negative device offsets and negative lengths,
telling the user what the offending option and value were.

Signed-off-by: Brian Norris <computersforpeace at gmail.com>
---
 nanddump.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/nanddump.c b/nanddump.c
index b0dd7dc..9f52878 100644
--- a/nanddump.c
+++ b/nanddump.c
@@ -173,6 +173,13 @@ static void process_options(int argc, char * const argv[])
 		}
 	}
 
+	if (start_addr < 0)
+		errmsg_die("Can't specify negative offset with option -s: %lld",
+				start_addr);
+
+	if (length < 0)
+		errmsg_die("Can't specify length with option -l: %lld", length);
+
 	if (quiet && pretty_print) {
 		fprintf(stderr, "The quiet and pretty print options are mutually-\n"
 				"exclusive. Choose one or the other.\n");
-- 
1.7.0.4





More information about the linux-mtd mailing list