[PATCH 0/3] MTD: OneNAND: Fix OneNAND DMA error handling and 2KiB pagesize

Artem Bityutskiy dedekind1 at gmail.com
Tue Aug 31 19:13:39 EDT 2010


On Tue, 2010-08-31 at 08:27 +0900, Kyungmin Park wrote:
> On Mon, Aug 30, 2010 at 9:52 PM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> > On Fri, 2010-08-27 at 11:55 +0900, Kyungmin Park wrote:
> >> Kyungmin Park (3):
> >>       MTD: OneNAND: Remove unused cmd_map at s5pc110
> >>       MTD: OneNAND: Fix loop hang when DMA error at Samsung SoCs
> >>       MTD: OneNAND: Fix 2KiB pagesize handling at Samsung SoCs
> >>
> >>  drivers/mtd/onenand/samsung.c |   17 +++++++----------
> >>  1 files changed, 7 insertions(+), 10 deletions(-)
> >
> > Taken patches 1 and 3, requested a change for patch 2. Pushed patches 1
> > and 3 to l2-mtd-2.6.git / dunno, thanks.
> 
> To David, Artem,
> Can you include these patches to linux-2.6.36-rc4? since it's bug fixes.
> 
> How do you think?

Note, Linus nowadays tends to be stricter about what goes in -rc. Why
would the first patch be a fix deserving urgent merging?

About the second patch, what if you was mistaken and 20msces is not
enough sometimes? Don't you afraid to introduce another bug with this?

Probably for 2.6.36 the older version of your patch can be merged, and
then you can add timeout support on top?

Third patch is probably ok, if you really want it in 2.6.36.

So, I've moved the third patch to l2-mtd-2.6.git / for-2.6.36, I've left
the first patch in the dunno branch, and I also put the original version
of the second patch to the for-2.6.36 branch.

Please, add timeout on top of l2-mtd-2.6.git / for-2.6.36 and send it.
I'll then take care of it, or at least try.

-- 
Best Regards,
Artem Bityutskiy (Битюцкий Артём)




More information about the linux-mtd mailing list