[PATCH v3] Fix mtd-utils bugs

Artem Bityutskiy dedekind1 at gmail.com
Fri Aug 20 01:29:28 EDT 2010


On Wed, 2010-06-23 at 17:16 +0200, Ladislav Michl wrote:
> On Sun, Jun 20, 2010 at 08:22:57PM +0800, Stanley.Miao wrote:
> > Changes from V2:
> > 1, Get the linux version via uname() according to Joakim Tjernlund.
> > 2, Set the default version the latest version according to Joakim Tjernlund.
> > 
> > The "struct nand_oobinfo" is able to record only 32 ECC code positions,which
> > is not enough for many big NAND chips. Therefore, this structure is replaced
> > by "struct nand_ecclayout" in linux kernel from the version 2.6.17.
> > Consequently, the ioctl command changed from MEMGETOOBSEL to ECCGETLAYOUT.
> > 
> > Now update nandwrite to use the new ioctl command ECCGETLAYOUT. In order to
> > keep compatible with the old linux kernel, a linux version detection function
> > is added.
> > 
> > YAFFS and JFFS2 has updated and we don't need the arguments "forcelegacy",
> > "forcejffs2", "forceyaffs" anymore. Now clean them up. 
> 
> Tested with linux-2.6.32 (flash_eraseall -j finaly works now)
> 
> Tested-by: Ladislav Michl <ladis at linux-mips.org>
> 
> As a special bonus, here is simple patch on top of your patchset making
> flash_eraseall smaller:
> 

FYI, this patch is still sitting in my mailbox and waiting - Stanley's
stuff was not merged, and this patch depends on that. So, if you can
make it to be independent, please, re-send. Stanley said he'd re-send
the patch.

But also there is some ongoing discussion to deprecate ECCGETLAYOUT, but
I did not read it yet.

Artem.





More information about the linux-mtd mailing list