[Uclinux-dist-devel] [PATCH 4/7] mtd: Blackfin NFC: wait for the ECC reset to finish

[Barry Song]

On Thu, Aug 5, 2010 at 11:16 PM, David Woodhouse <dwmw2 at infradead.org> wrote:
> On Thu, 2010-08-05 at 11:07 -0400, Mike Frysinger wrote:
>>
>> +       while (bfin_read_NFC_RST() & ECC_RST)
>> +               cpu_relax();
>
> All applied, but I'd be happier if this one had some kind of timeout and
> didn't have the potential to loop forever if the hardware misbehaves.
If this loop forever, it means a chip bug and really has no any way to
continue to run the system. So the point is "bfin_read_NFC_RST() &
ECC_RST" will must be real for the right chip, if the chip has bug,
there should be workaround but not a timeout.

>
> --
> David Woodhouse                            Open Source Technology Centre
> David.Woodhouse at intel.com                              Intel Corporation
>
>
> _______________________________________________
> Uclinux-dist-devel mailing list
> Uclinux-dist-devel at blackfin.uclinux.org
> https://blackfin.uclinux.org/mailman/listinfo/uclinux-dist-devel
>