[PATCH 2/7] UBIFS: do not treat ENOSPC specially

Vitaly Wool vitalywool at gmail.com
Sun Aug 8 13:51:37 EDT 2010


Hi Artem,

On Sat, Aug 7, 2010 at 4:26 AM, Artem Bityutskiy <dedekind1 at gmail.com> wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
>
> 'ubifs_garbage_collect_leb()' should never return '-ENOSPC', and if it
> does, this is an error. Thus, do not treat this error code specially.
> '-EAGAIN' is a special error code, but not '-ENOSPC'.
>
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
> ---
>  fs/ubifs/gc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c
> index f89a422..29ce1b3 100644
> --- a/fs/ubifs/gc.c
> +++ b/fs/ubifs/gc.c
> @@ -677,7 +677,7 @@ int ubifs_garbage_collect(struct ubifs_info *c, int anyway)
>
>                ret = ubifs_garbage_collect_leb(c, &lp);
>                if (ret < 0) {
> -                       if (ret == -EAGAIN || ret == -ENOSPC) {
> +                       if (ret == -EAGAIN) {
>                                /*
>                                 * These codes are not errors, so we have to
>                                 * return the LEB to lprops. But if the

(just passing by...) probably the comment should be updated as well?

Thanks,
   Vitaly



More information about the linux-mtd mailing list