[PATCHv2 3/9] UBIFS: fix assertion warning
Artem Bityutskiy
dedekind1 at gmail.com
Sun Aug 8 05:57:26 EDT 2010
From: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
This patch fixes the following false assertion warning:
UBIFS assert failed in data_nodes_cmp at 130 (pid 15107)
The assertion was wrong because it did not take into account that the
node can be an xentry.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
---
fs/ubifs/gc.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c
index 29ce1b3..d060c62 100644
--- a/fs/ubifs/gc.c
+++ b/fs/ubifs/gc.c
@@ -178,7 +178,8 @@ int nondata_nodes_cmp(void *priv, struct list_head *a, struct list_head *b)
if (typeb == UBIFS_INO_KEY)
return 1;
- ubifs_assert(typea == UBIFS_DENT_KEY && typeb == UBIFS_DENT_KEY);
+ ubifs_assert(typea == UBIFS_DENT_KEY || typea == UBIFS_XENT_KEY);
+ ubifs_assert(typeb == UBIFS_DENT_KEY || typeb == UBIFS_XENT_KEY);
inuma = key_inum(c, &sa->key);
inumb = key_inum(c, &sb->key);
--
1.7.1.1
More information about the linux-mtd
mailing list