[PATCHv2 1/9] UBIFS: switch to RO mode after synchronizing

Artem Bityutskiy dedekind1 at gmail.com
Sun Aug 8 05:57:24 EDT 2010

From: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>

In 'ubifs_garbage_collect()' on error path, we first switch to R/O mode, and
then synchronize write-buffers (to make sure no data are lost). But the GC
write-buffer synchronization will fail, because we are already in R/O mode.
This patch re-orders this and makes sure we first synchronize the write-buffer,
and then switch to R/O mode.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy at nokia.com>
 fs/ubifs/gc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c
index 918d158..f89a422 100644
--- a/fs/ubifs/gc.c
+++ b/fs/ubifs/gc.c
@@ -774,8 +774,8 @@ out_unlock:
 	ubifs_assert(ret < 0);
 	ubifs_assert(ret != -ENOSPC && ret != -EAGAIN);
-	ubifs_ro_mode(c, ret);
+	ubifs_ro_mode(c, ret);
 	ubifs_return_leb(c, lp.lnum);
 	return ret;

More information about the linux-mtd mailing list