[PATCH v3 5/8] mtd: cfi_cmdset_0002: do not fail on no extended query table as they are both optional

[Chris Moore]

Hi,

Le 22/04/2010 10:36, Guillaume LECERF a écrit :

[snip]


>
> -		bootloc = extp->TopBottom;
> -		if ((bootloc != 2)&&  (bootloc != 3)) {
> -			printk(KERN_WARNING "%s: CFI does not contain boot "
> -			       "bank location. Assuming top.\n", map->name);
> -			bootloc = 2;
> -		}
> +			bootloc = extp->TopBottom;
> +			if ((bootloc != 2)&&  (bootloc != 3)) {
> +				printk(KERN_WARNING "%s: CFI does not contain boot "
> +				       "bank location. Assuming top.\n", map->name);
> +				bootloc = 2;
> +			}
>
>    

[snip]

It is not your fault, Guillaume, but this whole "Assuming top" stuff is 
completely bogus :(
(The most obvious, but not the only, bug is that it actually sets 
bootloc to 2 which is bottom :( )

Uwe Kleine-Koenig submitted a patch for this ages ago which I tried to 
ping. See these threads :
http://thread.gmane.org/gmane.linux.drivers.mtd/22176
http://thread.gmane.org/gmane.linux.drivers.mtd/22266

*Please*, David, could we get this cleaned up?

Cheers,
Chris