[PATCH v2 3/7] mtd: cfi_probe: add support for SST 0x0701 vendorname

[Wolfram Sang]

On Thu, Apr 08, 2010 at 11:05:53AM +0200, Wolfram Sang wrote:
> On Tue, Mar 30, 2010 at 03:34:58PM +0200, Guillaume LECERF wrote:
> > SST 39VF160x and 39VF320x chips use vendorname id 0x0701 and alternative
> > unlock addresses. Add support for them in cfi_probe.c.
> > 
> > Signed-off-by: Guillaume LECERF <glecerf at gmail.com>
> > ---
> >  drivers/mtd/chips/cfi_probe.c |    9 +++++++++
> >  include/linux/mtd/cfi.h       |    1 +
> >  2 files changed, 10 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
> > index a28659d..f931e94 100644
> > --- a/drivers/mtd/chips/cfi_probe.c
> > +++ b/drivers/mtd/chips/cfi_probe.c
> > @@ -214,6 +214,12 @@ static int __xipram cfi_chip_setup(struct map_info *map,
> >  	 * back into Read Mode, which is a nop in this case).
> >  	 */
> >  	cfi_send_gen_cmd(0xf0,     0, base, map, cfi, cfi->device_type, NULL);
> > +
> > +	if (cfi->cfiq->P_ID == P_ID_SST_OLD) {
> > +		addr_unlock1 = 0x5555;
> > +		addr_unlock2 = 0x2AAA;
> > +	}
> 
> Can't we set cfi->addr_unlock[12] here already? This way, we could later have
> just one fixup function for all old SST flashes.

Well, even if there is a way to do it (by replacing the NULL-checks of
addr_unlock[12] in cfi_cmdset_0002() with something else), it can be applied
later and on top of this series.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20100412/1b42e5b7/attachment.sig>