[PATCH] [MTD] bcmring: mtd nand driver

[Scott Branden]

> -----Original Message-----
> From: linux-mtd-bounces at lists.infradead.org 
> [mailto:linux-mtd-bounces at lists.infradead.org] On Behalf Of 
> Leo (Hao) Chen
> Sent: September 29, 2009 5:02 PM
> To: David Woodhouse
> Cc: Linux MTD
> Subject: Re: [PATCH] [MTD] bcmring: mtd nand driver
> 
> Hi,
> 
> Please check the updated version of this patch for bcmring nand driver
> support.
> 
> I've removed superfluous comments, added platform resource, 
> added a new
> kernel option to replace the USE_HWECC macro.
> 
> Please comment.
> 
> Thanks,
> 
> Leo
> 
> From 398b8fbfd219ee20f2eb76101992d6153ce8b52e Mon Sep 17 00:00:00 2001
> From: Leo Chen <leochen at broadcom.com>
> Date: Mon, 28 Sep 2009 14:11:49 -0700
> Subject: [PATCH] add bcmring mtd nand driver support
> 
> Add mtd umi driver for bcmring arm arch.
> Add header files, register definition files,
> add entry in Kconfig and Makefile.
> 
> remove superfluous comments from bcm nand driver
> use platform resource
> 
> add CONFIG_MTD_NAND_BCM_UMI_HWECC option to replace USE_HWECC macro
> 
> diff --git a/arch/arm/configs/bcmring_defconfig 
> b/arch/arm/configs/bcmring_defconfig
> index bcc0bac..789794e 100644
> --- a/arch/arm/configs/bcmring_defconfig
> +++ b/arch/arm/configs/bcmring_defconfig
> @@ -416,6 +416,7 @@ CONFIG_MTD_NAND_VERIFY_WRITE=y
>  CONFIG_MTD_NAND_IDS=y
>  CONFIG_MTD_NAND_BCM_UMI=y
>  CONFIG_MTD_NAND_BCM_UMI_HWCS=y
> +CONFIG_MTD_NAND_BCM_UMI_HWECC=y

There is no need for an additional CONFIG option.  Just always use HWECC and delete the soft code.