[PATCH 1/2] UBI: Add ubi_open_volume_path()

Artem Bityutskiy dedekind1 at gmail.com
Tue Sep 29 10:27:37 EDT 2009


On Mon, 2009-09-28 at 21:10 +0200, Corentin Chary wrote:
> Add an ubi_open_volume_path(path, mode) function which works like
> open_bdev_exclusive(path, mode, ...) where path is the special file
> representing the UBI volume, typically /dev/ubi0_0.
> 
> Signed-off-by: Corentin Chary <corentincj at iksaif.net>

Looks good, and actually works. And I like that I can now do:

mount -t ubifs /dev/ubi_whatever_name /mnt/ubifs

And when your user-space changes hit distros, I will not have to
even specify -t ubifs.

I'm not entirely sure vs the 'kern_path()' usage though. Could you
please post your patch to these lists as well:

linux-fsdevel at vger.kernel.org
linux-kernel at vger.kernel.org

I'll push your patches to the ubi-2.6.git now, but I would not want to
make these changes sneak into mainline without being sent to lkml, just
because I'm not entirely sure about the 'kern_path()'. But for me this
looks ok.

Thanks!

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)




More information about the linux-mtd mailing list