[PATCH v2] mtd/maps: gpio-addr-flash: new driver for GPIO assisted flash addressing

[Mike Frysinger]

On Sun, Sep 20, 2009 at 21:56, David Woodhouse wrote:
> On Sun, 2009-09-20 at 21:35 -0400, Mike Frysinger wrote:
>> On Sun, Sep 20, 2009 at 21:25, David Woodhouse wrote:
>> > On Sun, 2009-09-20 at 18:49 -0400, Mike Frysinger wrote:
>> >> i think you mean:
>> >> depend GPIOLIB || GENERIC_GPIO
>> >
>> > No, I think the failing configuration was GENERIC_GPIO && !GPIOLIB
>> >
>> > With GENERIC_GPIO, we include <asm-generic/gpio.h>, and _without_
>> > GPIOLIB that header doesn't actually do anything useful.
>>
>> i dont know what you mean by "we". GENERIC_GPIO means asm/gpio.h is
>> useful and so provides the basic gpio functions (which this driver
>> uses).  the driver, nor common gpio.h headers, pull in
>> asm-generic/gpio.h.
>>
>> that is how the Blackfin arch works.  GENERIC_GPIO -> basic gpio
>> functions work fine as the on-chip gpio functions are supported.
>
> On i386, <linux/gpio.h> includes <asm/gpio.h>. And that includes
> <asm-generic/gpio.h> -- which only does anything useful if
> CONFIG_GPIOLIB is set.
>
> The failed compilation I showed you earlier was with CONFIG_GENERIC_GPIO
> set, but not CONFIG_GPIOLIB.

that isnt a valid GENERIC_GPIO implementation.  x86 cant support it
w/out GPIOLIB.  so the depend still should be "(GENERIC_GPIO ||
GPIOLIB)".
-mike