[PATCH 2/2] MTD: OneNAND: multiblock erase support

[Kyungmin Park]

On Fri, Sep 18, 2009 at 2:03 PM, Mika Korhonen
<ext-mika.2.korhonen at nokia.com> wrote:
> Hunter Adrian (Nokia-D/Helsinki) wrote:
>>
>> Korhonen Mika.2 (EXT-Ardites/Oulu) wrote:
>>
>>>
>>> Add support for multiblock erase command. OneNANDs (excluding
>>> Flex-OneNAND)
>>> are capable of simultaneous erase of up to 64 eraseblocks which is much
>>> faster.
>>> This changes the erase requests for regions covering multiple eraseblocks
>>> to be performed using multiblock erase.
>>>
>>> Signed-off-by: Mika Korhonen <ext-mika.2.korhonen at nokia.com>
>>> ---
>>>
>>
>> A few comments below.
>>
>>
>
> [...]
>>
>> +               switch (state) {
>> +               case FL_RESETING:
>> +                       intr_flags |= ONENAND_INT_RESET;
>> +                       break;
>> +               case FL_PREPARING_ERASE:
>> +                       intr_flags |= ONENAND_INT_ERASE;
>> +                       break;
>> +               case FL_VERIFYING_ERASE:
>> +                       i = 51;
>>
>> I see 100us for this in some versions.  Perhaps Kyungmin can suggest
>> a value.
>>
>
> With the chip I had the actual time for 64-eb verify read was in the range
> of 20-30 us but you're right, there are chips for which the maximum time is
> specified to be 100 us. Is ok to just raise this to that value? Kyungmin?

To correctness, It should be 100 as Spec.

Just FYI:
In recent OneNAND chips has 4KiB pagesize doesn't support Multi block
erase feature at my spec.

Right, these chips are not yet support at MTD. After make a patch, we
have to check the multi block erase feature.

Thank you,
Kyungmin Park