[PATCH] Samsung SoCs: OneNAND support

[Russell King - ARM Linux]

On Thu, Sep 17, 2009 at 05:16:59PM +0900, Kyungmin Park wrote:
> +#include <asm/io.h>

Please make sure that you use linux/io.h

> +static int s3c_onenand_probe(struct platform_device *pdev)
> +{
> +	struct onenand_platform_data *pdata;
> +	struct onenand_chip *this;
> +	struct mtd_info *mtd;
> +	struct resource *r;
> +	int size, err;
> +	unsigned long ahb_addr = 0, ahb_addr_size;
> +
> +	if (!(cpu_is_s3c64xx() || cpu_is_s5pc1xx()))
> +		return -ENODEV;

Isn't it normal to leave these kind of decisions to the declaration of
the devices, rather than encoding it into the driver?