[PATCH] [OneNAND] OTP support re-implementation 1/1

Amul Kumar Saha amul.saha at samsung.com
Thu Sep 3 06:37:52 EDT 2009


>> >> +
>> >> +config ONENAND_OTP_AREA_BLOCK0
>> >> + bool "BOTH OTP area AND Block[0]"
>> >> + depends on MTD_ONENAND_OTP&&  !ONENAND_OTP_AREA&&  !ONENAND_OTP_BLOCK0
>> >> + select ON_OTP_AREA_BLOCK0
>> >> +
>> >> +endif #MTD_ONENAND_OTP
>> >
>> > If there were 10 OTP blocks, would you add 10 options?
>> > I mean, are these switches really needed? Can we remove them?
>>
>> There is just one OTP block.
>> Three options are provided for the three known combinations of 1st Block and the OTP Block.
>> The option to choose one should be provided to the user.
>
> Wouldn't it be better to  make this run-time configurable? E.g., module
> parameters? Too many config options are frowned upon usually.
>

I got it. But I guess in this case the numbers are not that big enough to call for Module parameters 
implementation.
Is it okay?

With Regards,
Amul Kumar Saha 





More information about the linux-mtd mailing list