[PATCH 2/2] mkfs.ubifs: use libubi to format UBI volume

[Artem Bityutskiy]

On Mon, 2009-05-25 at 10:23 +0200, Corentin Chary wrote:
> On Mon, May 25, 2009 at 9:58 AM, Artem Bityutskiy
> <dedekind at infradead.org> wrote:
> >
> > I know this is nit-picking, but would be nicer to close libubi
> > in case of errors. Namely, in the second and third checks.
> 
> In case of error, close_target() will close libubi. (if(ubi) libubi_close(ubi)).
> But maybe you want to explicitly close libubi here ?

Ah, OK. NP then.

> The comma is just at the 80 column limit.
> Using Lindent, we get:
>                         return
>                             sys_err_msg("bad root file-system directory '%s'",
>                                         root);
> 
> Is this ok ?

I think you may just ignore the 80 chars limit and make it 81 chars :-)

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)