[PATCH 3/5] mtd: nand: atmel: use default ecc layout

Troy Kisky troy.kisky at boundarydevices.com
Wed May 20 14:28:09 EDT 2009


Nicolas Ferre wrote:
> Hi,
> 
> I would like to bring my 2cents to the discussion so, let me comment simultaneously on:
> [PATCH 1/5] mtd: nand: move layout structure into nand_ecc_ctrl
> [PATCH 3/5] mtd: nand: atmel: use default ecc layout
> 
> First of all I did not manage to compile without this additional line in atmel_nand.c (which is not in original patch):
> 
> --- a/drivers/mtd/nand/atmel_nand.c
> +++ b/drivers/mtd/nand/atmel_nand.c
> @@ -329,7 +303,7 @@ static int atmel_nand_calculate(struct m
>  {
>  	struct nand_chip *nand_chip = mtd->priv;
>  	struct atmel_nand_host *host = nand_chip->priv;
> -	uint32_t *eccpos = nand_chip->ecc.layout->eccpos;
> +	uint32_t *eccpos = nand_chip->ecc.layout.eccpos;
>  	unsigned int ecc_value;
>  
>  	/* get the first 2 ECC bytes */
> 

My patch set is on top of Linux 2.6.30-rc5.



More information about the linux-mtd mailing list