[PATCH 3/5] mtd: nand: atmel: use default ecc layout

Troy Kisky troy.kisky at boundarydevices.com
Fri May 15 19:04:13 EDT 2009


Richard Genoud wrote:
> 2009/5/16 Troy Kisky <troy.kisky at boundarydevices.com>:
>> I think you are wrong. It is definitely not what I intended.
>> The logic should say, "If I can place the ecc at the beginning I will,
>> otherwise, I will place it at the end." With the bad block marker
>> at 0, it should choose the end.
>>
>> Troy
>>
> You're right, I missed that.
> So, for atmel_nand, nothing changes, and the hardware ecc code will
> still be correct.
> Maybe you could add a little comment in the code explaining the logic,
> as you just did.
> 
> Acked-by: Richard Genoud <richard.genoud at gmail.com>

Ok, I will. Thanks for the review.

Troy




More information about the linux-mtd mailing list