[PATCH] [REPOST] mtd: extend plat_nand for (read|write)_buf
alex at digriz.org.uk
Fri May 15 11:05:49 EDT 2009
* Artem Bityutskiy <dedekind at infradead.org> [2009-05-15 16:51:00+0300]:
> On Mon, 2009-05-11 at 19:28 +0100, Alexander Clouter wrote:
> > This patch adds (write|read)_buf callbacks to plat_nand.
> > The NAND on the TS-7800 provisioned by the FPGA allows readw() and
> > readl() to be used which gives a 2.5x speed up. To be able to use this
> > from the plat_nand driver a hook for read_buf (and also write_buf whilst
> > we are in there) need to be made available. This patch adds the hook.
> > This is a repost of a feature asked for before, plus other helpful
> > patches to plat_nand would be welcomed if at all possible too.
> >  http://lists.infradead.org/pipermail/linux-mtd/2009-March/024747.html
> >  http://lists.infradead.org/pipermail/linux-mtd/2007-October/019659.html
> >  http://lists.infradead.org/pipermail/linux-mtd/2009-March/024780.html
> > Signed-off-by: Alexander Clouter <alex at digriz.org.uk>
> I think this should be submitted with the user at the same
> time. Adding hooks without having a user is not very good.
> E.g., you may find out later that this does not help, or
> cancel your project, or end up with different call-backs,
In the case of read/write_buf...there is no other way, I'm all ears if
you know how I can do (read|write)(w|l) with plat_nand *now*?
I just pulled off this type of manoeuvre for a HW RNG driver:
I doubt the ARM people would be happy if I push ARM patches through the
MTD sub-system :)
> You may keep this patch privately, work on your NAND driver,
> and when you have it ready, you submit it with this at the
> same time.
Erm, it's been ready for a *long* time, about a year, and is being
used. Recently the bits of my plat_nand impementation is on it's way
to going mainline (Orion -> ARM -> Linus):
.sigmonster says: Your fly might be open (but don't check it just now).
More information about the linux-mtd