[PATCH 4/5] mtd: nand: cafe_nand: use default ecc layout
troy.kisky at boundarydevices.com
Thu May 14 17:18:38 EDT 2009
David Brownell wrote:
> On Wednesday 13 May 2009, Troy Kisky wrote:
>> The bad block marker is at 14, but oobfree also
>> starts at 14. This doesn't make sense to me,
> On-chip bad-block tables stick the "Bbt0" (etc)
> tags into the OOB data area, and don't need to
> share that area with anything else. It's OK.
>> so I don't know if this patch is good or not.
> Isn't this one of the drivers using NAND_ECC_HW_SYNDROME?
> So that the ecclayout is fully defined by prepad==0?
> This is a case where you *could* safely generate the
> current ecclayout structs using simple rules.
Actually, cafe_nand overrides most everything and doesn't use
prepad or postpad or ecc.layout. But I think it still relies
on ecc.layout.oobfree to setup chip->oob_poi. So, I'm no closer
to understanding why oobfree and bad block marker start at 14.
More information about the linux-mtd