[PATCH 1/2] mkfs.ubifs: UBI I/O Library

Artem Bityutskiy dedekind at infradead.org
Fri May 8 04:49:23 EDT 2009


Hi,

thanks for patches. Could you please avoid synchronizing 
include/mtd/ubi-user.h for now? There is nothing new there
except of this insane s/int32_t/__s32/ type change, right?

On Thu, 2009-05-07 at 12:21 +0200, Corentin Chary wrote:
>  include/mtd/ubi-user.h    |   72 ++--
>  include/ubi.h             |  192 +++++++++
>  mkfs.ubifs/libubiio.c     |  936 +++++++++++++++++++++++++++++++++++++++++++++
>  mkfs.ubifs/libubiio.h     |   47 +++
>  mkfs.ubifs/libubiio_int.h |  187 +++++++++
>  5 files changed, 1399 insertions(+), 35 deletions(-)
>  create mode 100644 include/ubi.h
>  create mode 100644 mkfs.ubifs/libubiio.c
>  create mode 100644 mkfs.ubifs/libubiio.h
>  create mode 100644 mkfs.ubifs/libubiio_int.h

What is the point of making a second copy of libubi?
AFAICS, libubio is libubi + other stuff, right?
Why not to just improve libubi instead of having yet
another copy? How much sense does it make?

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)




More information about the linux-mtd mailing list