[PATCH] [MTD] devices/mtd_dataflash: Add SW sector protection support

[Mike McTernan]

On Monday 23 March 2009 20:36, David Brownell wrote:

> I took a really quick look at this. 

Many thanks.

> The terminology is confusing ... there are now two kinds 
> of "sector" in the driver.  Call one of them "lock sector"
> or somesuch,

It's as per the datasheet figure 4-1; the device has pages, blocks and
sectors.  Blocks aren't very interesting so are not in the driver, but
pages and sectors are.  But I see only one use of sectors in this
driver, what am I missing?

> so it makes sense to check the count of such sectors

Could you clarify what you mean here?

> stylistically, it'd be better not to #ifdef the guts of
> the lock/unlock methods.  #define them as NULL when
> SWPROT is not configured, and don't even set those
> methods for devices that don't support those ops.

That's easily changed.

Kind Regards,

Mike