Is high_memory check in omap2.c for OneNAND is sufficient?

Adrian Hunter adrian.hunter at nokia.com
Tue Mar 24 11:44:10 EDT 2009


Singh, Vimal wrote:
> There is check for 'high_memory' in 'drivers/mtd/onenand/omap2.c', always before doing 'dma_map_single'.
> Snippet:
> ----------------------
>         if (buf >= high_memory) {
>                 struct page *p1;
> ----------------------
> This check seems not sufficient. There should be a check for upper boundary too.
> Thinking scenario when 'buf' is less than 'high_memory', but somewhere near to it, and 'count' is big enough to beyond 'high_memory'.

AFAIK it is not possible to allocate memory that crosses the high_memory boundary.




More information about the linux-mtd mailing list