[PATCH 1/2] [MTD] CORE: New ioctl calls for >4GiB device support (take 2)
Adrian Hunter
adrian.hunter at nokia.com
Fri Mar 20 04:11:10 EDT 2009
Kevin Cernekee wrote:
> Extend the MTD user ABI to access >4GiB devices using 64-bit offsets.
> Add compat_ioctl support to the MTD ABI.
>
> New ioctls: MEMABIINFO MEMGETINFO64 MEMERASE64 MEMWRITEOOB64 MEMREADOOB64
> MEMLOCK64 MEMUNLOCK64 MEMGETREGIONINFO64
>
> Signed-off-by: Kevin Cernekee <kpc.mtd at gmail.com>
> ---
> drivers/mtd/compat_ioctl.c | 233 +++++++++++++
> drivers/mtd/compat_ioctl.h | 89 +++++
> drivers/mtd/mtdchar.c | 817 ++++++++++++++++++++++++++++---------------
> include/mtd/mtd-abi.h | 69 ++++-
> include/mtd/mtd-user.h | 4 +
> 5 files changed, 921 insertions(+), 291 deletions(-)
> create mode 100644 drivers/mtd/compat_ioctl.c
> create mode 100644 drivers/mtd/compat_ioctl.h
>
> diff --git a/drivers/mtd/compat_ioctl.c b/drivers/mtd/compat_ioctl.c
> new file mode 100644
> index 0000000..ee98f71
> --- /dev/null
> +++ b/drivers/mtd/compat_ioctl.c
> @@ -0,0 +1,233 @@
> +/*
> + * MTD compat_ioctl implementation
That is not how it is done. See fs/compat_ioctl.c
<snip>
>
> +struct mtd_abi_info {
> + uint32_t major;
> + uint32_t minor;
> + uint32_t patchlevel;
> + uint32_t res0[8];
> +};
> +
ioctl versioning is unlikely to be accepted by the wider community.
Try posting to LKML for more feedback on that.
More information about the linux-mtd
mailing list