[PATCH] [MTD] mtd-utils: Use new 64-bit ioctls to access >4GiB devices

Adrian Hunter adrian.hunter at nokia.com
Wed Mar 18 08:16:04 EDT 2009


Josh Boyer wrote:
> On Wed, Mar 18, 2009 at 08:50:08AM +0100, Ricard Wanderlof wrote:
>> On Wed, 18 Mar 2009, Kevin Cernekee wrote:
>>
>>> This patch depends on "CORE: New ioctl calls for >4GiB device support".
>>>
>>> Use the new kernel ioctls to support >4GiB flash devices in mtd-utils.
>>> -               if(ioctl(Fd,MEMGETREGIONINFO,&(reginfo[i])) != 0)
>>> +               if(ioctl(Fd,MEMGETREGIONINFO64,&(reginfo[i])) != 0)
>> Wouldn't it be an idea to support both the old and new calls for a while  
>> (using compile time switching), in case someone wants to grab a newer  
>> version of mtdtools but doesn't have a newer kernel for whatever reason?
> 
> Yes, it would.  In fact, it would be better to probably add a new
> --large-device (or similar) option to all the utilities so that
> they can use both with a runtime switch.

I would suggest just trying MEMGETINFO64 and if it returns ENOTTY
then switch to the old ioctls.



More information about the linux-mtd mailing list