[PATCH] [MTD] phram: cleanup error handling and associated messages

Jörn Engel joern at logfs.org
Wed Jun 17 07:24:50 EDT 2009

On Wed, 17 June 2009 06:50:18 -0400, Mike Frysinger wrote:
> The error handling in the phram driver is pretty bad -- in many places,
> errors are silently ignored or logged, but then still ignored in the
> return value.  So convert all of the code to pass back the correct return
> value and log error messages properly (and using the new pr_fmt() helper).

I don't remember why I always returned 0 in phram_setup.  Could well
have been an oversight.

> If everything does go smoothly, rather than exit silently, dump a helpful
> info message like pretty much every other MTD driver does.
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>

Acked-by: Joern Engel <joern at logfs.org>

Care to take over maintainership?  I haven't used this driver in ages
and don't foresee using it anytime soon.


You cannot suppose that Moliere ever troubled himself to be original in the
matter of ideas. You cannot suppose that the stories he tells in his plays
have never been told before. They were culled, as you very well know.
-- Andre-Louis Moreau in Scarabouche

More information about the linux-mtd mailing list