[PATCH 2/2] mtd/nand: Fix tmio_nand ecc correction

Atsushi Nemoto anemo at mba.ocn.ne.jp
Thu Jul 30 19:54:11 EDT 2009

On Tue, 28 Jul 2009 18:12:40 +0100, Ian molton <spyro at f2s.com> wrote:
> This looks fine to me, but as I said, wouldnt it be better to implement 
> the 6-byte ecc in the core if theres more than one chip that can use it?
> no point in duplicating code...

Yes, but I wonder how popular 6-byte ecc per 512 byte block compared
to other combinations.  For now, keep tmio_nand_correct_data in
tmio_nand driver would be reasonable.

If many (well, two might not be enough :-)) xxx_nand_correct_data do
same thing, we can refactor them easily.

Atsushi Nemoto

More information about the linux-mtd mailing list