vimal singh wrote: > What if you go to 'err_out' due to some other error?? Do not you need > to free 'info'? We have to and of_flash_remove() takes care of it. The initial patch would be shorter if dev_set_drvdata(&dev->dev, info); would be moved prior the kzalloc() Sebastian