[PATCH V5 1/2] Nand driver for Nomadik 8815 SoC (on NHK8815 board)

[vimal singh]

On Mon, Jul 27, 2009 at 11:58 AM, vimal singh<vimal.newwork at gmail.com> wrote:
> On Fri, Jul 24, 2009 at 6:07 PM, Alessandro Rubini<rubini-list at gnudd.com> wrote:
>>> Please run ''checkpatch.pl' for this patch and try to fix the errors.
>>
>> Ok, will do. Although I don't agree with everything checkpatch is
>> saying (I've heard checkpatch is meant as suggestions, to be
>> considered but not applied blindly, so I behaved accordingly).
>>
>>> this can be 'NAND_ECC_SOFT' here... then
>>
>> As explained in the comments above, there is the hardware in there,
>> only I've not been able to use it yet. So I prefer to stay HW and then
>> change as little as possible.  But, unless you confirm I can do that,
>> I'll write SOFT in there as requested.
>
> As of now, I think you can make it 'NAND_ECC_SOFT'. And then once you
> are able to use HW ECC, you can change it back.
> Currently making it HW confuses with wrong API being used in
> 'nand_base.c' (uses nand_'read/write'_page_hwecc rather than
> nand_read/write_page_swecc routines), although it does not make much
> difference in functionality.
>
To make it work for 512 bytes sector ECC in SW, below patch is required:

http://patchwork.ozlabs.org/patch/13697/

Which was posted sometime back, but unfortunately did not get merged.

David,

Can we get this patch merged? If required, I will post updated patch
after re-basing.

-vimal

>>
>> Will repost on monday, I'm off for the weekend.
>>
>> /alessandro
>>
>



-- 
---
Regards,
\/ | |\/| /-\ |_

____      __o
------   -\<,
-----  ( )/ ( )