[PATCH v3 26/27] [ARM] [NAND] [bcmring] add bcmring umi nand driver support

[Leo (Hao) Chen]

I had accidentally included an older version of the mtd driver patch, which has all the coding style problems.  I'm attaching a new patch with most of the coding style fixed except for the line length > 80 warnings.  Please check the attached patch in text/plain format.

Thanks for your advices.

 
Leo Hao Chen
Software Engineer
Broadcom Canada Inc.

 

> -----Original Message-----
> From: Steve Chen [mailto:schen at mvista.com] 
> Sent: Sunday, July 19, 2009 3:56 AM
> To: Artem Bityutskiy
> Cc: Leo (Hao) Chen; linux-arm-kernel at lists.arm.linux.org.uk; 
> linux-mtd at lists.infradead.org
> Subject: Re: [PATCH v3 26/27] [ARM] [NAND] [bcmring] add 
> bcmring umi nand driver support
> 
> On Sun, 2009-07-19 at 08:08 +0300, Artem Bityutskiy wrote:
> > On Fri, 2009-07-17 at 12:13 -0700, Leo (Hao) Chen wrote:
> > > This patch addes bcmring umi nand driver support, with 
> bch ecc algorithm support.
> > > 
> > > It addes header files, register files, Kconfig option and Makefile
> > > entry.
> > > 
> > > Signed-off-by: Leo Chen <leochen at broadcom.com>
> > 
> > Hi, the code neat in general, but would it be possible to 
> amend it and
> > make more compatible with the Linux coding style?
> > 
> > See Documentation/CodingStyle
> > See scripts/checkpatch.pl
> > 
> 
> Just to give an example of Artem's comment.  If I run the checkpatch
> script on this patch, I get
> 
> > scripts/checkpatch.pl add_bcmring_umi_nand_driver_support.patch
> 
> WARNING: space prohibited between function name and open 
> parenthesis '('
> #157: FILE: arch/arm/mach-bcmring/include/mach/reg_nand.h:47:
> +#define REG_NAND_DATA8          __REG8 (REG_NAND_PHYS_DATA8)
> 
> WARNING: line over 80 characters
> #220: FILE: arch/arm/mach-bcmring/include/mach/reg_umi.h:38:
> +#define HW_UMI_BASE       MM_IO_BASE_UMI       /* Unified Memory
> Interface Ctrl Register */
> ...
> 
> ERROR: code indent should use tabs where possible
> #1849: FILE: include/linux/mtd/nand_bcm_umi.h:227:
> +               /* Flip bit */$
> 
> ERROR: code indent should use tabs where possible
> #1850: FILE: include/linux/mtd/nand_bcm_umi.h:228:
> +               nand_bcm_umi_bch_ecc_flip_bit(datap, errorLocation);$
> 
> total: 365 errors, 192 warnings, 1707 lines checked
> 
> add_bcmring_umi_nand_driver_support.patch has style problems, please
> review.  If any of these errors are false positives report them to the
> maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> Regards,
> 
> Steve
> 
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0026-add-bcmring-umi-nand-driver-support.patch
Type: application/octet-stream
Size: 60137 bytes
Desc: 0026-add-bcmring-umi-nand-driver-support.patch
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20090721/b8504dac/attachment-0001.obj>